Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favicon for custom themes #512

Closed
wants to merge 9 commits into from
Closed

Favicon for custom themes #512

wants to merge 9 commits into from

Conversation

prem-k-r
Copy link
Collaborator

@prem-k-r prem-k-r commented Jan 29, 2025 •
edited
Loading

📝 Description

Generate favicon for custom themes based on theme color
To check: https://prem-k-r.github.io/materialYouNewTab/

📸 Screenshots / 📹 Videos

✅ Checklist

  • I have read and followed the Contributing Guidelines.
  • I have tested my changes by installing them as an extension (not just running via localhost) to ensure it builds, installs, and works as expected.
  • I have tested these changes in at least Chrome and Firefox (other browsers if applicable).
  • Attached visual evidence of changes (screenshots or videos) if applicable.

@prem-k-r prem-k-r added the enhancement New feature or request label Jan 29, 2025
@prem-k-r prem-k-r mentioned this pull request Jan 29, 2025
Draft
4 tasks
@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Jan 29, 2025 •
edited
Loading

todo later: icon for dark themes

@prem-k-r prem-k-r marked this pull request as ready for review January 29, 2025 17:06
@prem-k-r prem-k-r requested a review from itz-rj-here January 30, 2025 06:43
@prem-k-r
Custom theme favicon
f7ebb39 
Moved to a separate file
itz-rj-here
itz-rj-here previously approved these changes Jan 30, 2025
View reviewed changes
@prem-k-r prem-k-r added the ready to merge The pull request is ready to merge label Jan 30, 2025
@prem-k-r prem-k-r requested a review from XengShi February 3, 2025 10:36
@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Feb 3, 2025

@XengShi can you please check and merge this.. if all ok
It will be better to merge this before #501

@prem-k-r prem-k-r removed the ready to merge The pull request is ready to merge label Feb 4, 2025
@prem-k-r prem-k-r marked this pull request as draft February 4, 2025 12:38
@prem-k-r prem-k-r marked this pull request as ready for review February 4, 2025 15:30
@prem-k-r prem-k-r marked this pull request as draft February 4, 2025 21:40
@itz-rj-here itz-rj-here added work in progress The issue is on progress to fix under discussion This request/suggestion is still under discussion labels Feb 5, 2025
@prem-k-r prem-k-r removed the work in progress The issue is on progress to fix label Feb 5, 2025
@prem-k-r prem-k-r closed this Feb 5, 2025
@prem-k-r prem-k-r deleted the custom-theme-favicon branch February 5, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itz-rj-here itz-rj-here itz-rj-here left review comments

@XengShi XengShi Awaiting requested review from XengShi

Assignees
No one assigned
Labels
enhancement New feature or request under discussion This request/suggestion is still under discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prem-k-r @itz-rj-here